provider/aws: allow local kinesis

[garrettheel]

Allow providing a custom endpoint for kinesis so that Terraform can provision locally (via tools like kinesalite).

The one thing I'm still not happy with is that valid IAM credentials are required even when only provisioning locally due to the early ValidateCredentials call. This also affects dynamodb_endpoint. Suggestions on how to fix this are welcome.

Thanks!

[apparentlymart]

Since awsConfig is a pointer I think you're just making a new reference to the same struct here and then mutating it, rather than copying it as I think you intended.

[garrettheel]

@apparentlymart Thanks for the note on copying the pointer, I've since updated this

[garrettheel]

Bump - anything you need from me to get this merged?

[catsby]

Can you help me understand the change to the DynamoDB connection?
It looks like the endpoint can no longer overwrite, it's not the only way.

Same for this Kinesis connection; if it's omitted, aws.String() will provide a pointer to "", which I imagine doesn't work

[garrettheel]

@catsby the change to the DynamoDB connection is just to remove some of the boilerplate of redefining the entire config object. It takes a copy of awsConfig and then sets Endpoint to the provided value (which may be empty, mimicking existing behavior).

I've tested this by overriding KinesisEndpoint (pointing to a local kinesalite) and not overriding it and both work as expected.

[catsby]

OK, thanks for the explanation

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.