schema: delete non existing values #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to set the value to an empty value so the state file does indeed change the value. Otherwise the obsolote value is still intact and doesn't get changed at all. This means `terraform show` still shows the obsolote value when the particular value is not existing anymore. This is due the AWS API which is returning a null instead of an empty string.
|
LGTM. |
|
Sorry for the delay on this - this LGTM. |
phinze
added a commit
that referenced
this pull request
Dec 9, 2015
schema: delete non existing values
bmcustodio
pushed a commit
to bmcustodio/terraform
that referenced
this pull request
Sep 26, 2017
* oss/master: changelog++ add support to use application default credentials to gcs storage backend (hashicorp#3257) Remove fake news about custom plugins Fix travis build on go 1.9 changelog++ stdout support for file backend via logger (hashicorp#3235) fix swallowed errors in pki package tests (hashicorp#3215) Fix API/AUTH/AppRole doc issue concerning bound_cidr_list (hashicorp#3205)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to set the value to an empty value so the state file does
indeed change the value. Otherwise the obsolote value is still
intact and doesn't get changed at all. This means
terraform showstill shows the obsolote value when the particular value is not
existing anymore. This is due the AWS API which is returning a null
instead of an empty string.
Fixes #3251