Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/digitalocean - Droplet Size Lowercase #3284

Merged
merged 1 commit into from
Oct 12, 2015

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Sep 18, 2015

Not sure if this is actually valid but

Fixes #3283

Enforcing lowercase on the DO Size. This is used for the sizeslug property of API calls - according to their docs this always looks to be lowercase on the slug. I cannot find any definite answer to this question though

…perty of API calls - according to their [docs](https://developers.digitalocean.com/documentation/v1/sizes/) this always looks to be lowercase on the slug. I cannot find any definite answer to this question though
@bryanl
Copy link

bryanl commented Sep 29, 2015

@stack72 we (DigitalOcean) support 4GB or 4Gb or 4gb as a valid slug. It'll return the lowercase version, though.

@stack72
Copy link
Contributor Author

stack72 commented Sep 30, 2015

Hi @bryanl my apologies for not explaining this. I didn't mean that DO only accepted lowercase :) This enforcing lowercase is because DO returns lowercase. If lowercase is not enforced in Terraform, then it can potentially force new resources :)

@phinze
Copy link
Contributor

phinze commented Oct 12, 2015

LGTM

phinze added a commit that referenced this pull request Oct 12, 2015
provider/digitalocean - Droplet Size Lowercase
@phinze phinze merged commit 22681c3 into hashicorp:master Oct 12, 2015
@stack72 stack72 deleted the do_size_slug branch October 12, 2015 13:45
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

digitalocean_droplet upper/lowercase problem
4 participants