provider/aws: DynamoDB Table ARN

[stack72]

After the DynamoDB table is created, the ARN wasn't being set. Fixes #3497

terraform [aws-dynamodb-table-arn●] % make testacc TEST=./builtin/providers/aws TESTARGS='-run=DynamoDb' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=DynamoDb -timeout 90m
=== RUN   TestAccAWSDynamoDbTable
[DEBUG] Adding LSI data to the table[DEBUG] Added 1 LSI definitions[DEBUG] Trying to create initial table state![DEBUG] Checking on table TerraformTestTable--- PASS: TestAccAWSDynamoDbTable (125.13s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    125.13s

[catsby]

Hey @stack72 – what do you think about instead of setting arn here, returning resourceAwsDynamoDbTableRead() instead of nil on 294 there?

[stack72]

@catsby I actually did that originally, but it was a heavy query and made the test time move from 125seconds to 281seconds.

I didn't think that degrading the resource by that much was worth it.

Happy to change it though - it does make it more consistent with the other resource

FYI, here are the test results to show the time differences:

terraform [aws-dynamodb-table-arn●] % make testacc TEST=./builtin/providers/aws TESTARGS='-run=DynamoDb' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=DynamoDb -timeout 90m
=== RUN   TestAccAWSDynamoDbTable
[DEBUG] Adding LSI data to the table[DEBUG] Added 1 LSI definitions[DEBUG] Trying to create initial table state![DEBUG] Checking on table TerraformTestTable--- PASS: TestAccAWSDynamoDbTable (125.13s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    125.149s


terraform [aws-dynamodb-table-arn●] % make testacc TEST=./builtin/providers/aws TESTARGS='-run=DynamoDb' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=DynamoDb -timeout 90m
=== RUN   TestAccAWSDynamoDbTable
[DEBUG] Adding LSI data to the table[DEBUG] Added 1 LSI definitions[DEBUG] Trying to create initial table state![DEBUG] Checking on table TerraformTestTable--- PASS: TestAccAWSDynamoDbTable (281.78s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    281.794s

[catsby]

TestAccAWSDynamoDbTable taks ~260 seconds for me as it is. I ran it this morning for 300 seconds as well. Looking at the code as well, I'm not sure what's in the read that could cause any explosion in read time, it seems to make a single(?) API call

make it more consistent with the other resource

It seems there are a few other properties that are not set as well until the next read, so that change makes sense to me

[stack72]

I'm happy with that :) Change is on it's way

[catsby]

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.