Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsphere: rename "vcenter_server" config parameter to something clearer #3522

Closed
phinze opened this issue Oct 15, 2015 · 4 comments · Fixed by #3718
Closed

vsphere: rename "vcenter_server" config parameter to something clearer #3522

phinze opened this issue Oct 15, 2015 · 4 comments · Fixed by #3718
Labels
provider/vsphere

Comments

@phinze
Copy link
Contributor

phinze commented Oct 15, 2015

@mkuzmin has suggested "vsphere_server" #3419 (comment)
@phinze
Copy link
Contributor Author

phinze commented Oct 15, 2015

refs #3419

@mkuzmin
Copy link
Contributor

mkuzmin commented Oct 15, 2015

Property name is fine, but I'd change the environment variable name from VSPHERE_VCENTER to VSPHERE_SERVER.

@tkak
Copy link
Contributor

tkak commented Oct 18, 2015

It is ok to change. Thanks!

@tkak tkak mentioned this issue Nov 1, 2015
Merged
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
provider/vsphere
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

provider/vsphere: rename vcenter_server config parameter to something clearer rakutentech/terraform
3 participants
@phinze @tkak @mkuzmin