Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add configuration to enable copying RDS tags to final snapshot #3529

Merged
merged 2 commits into from
Oct 30, 2015

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Oct 16, 2015

RDS by default does not copy any RDS Instance tags over to the final snapshot when you destroy a database. This PR adds an optional boolean to enable applying all RDS Instance tags to it's snapshot. It works in conjunction with the final_snapshot_identifier.

It doesn't look like RDS Clusters have this ability.

Unfortunately I can't seem to find how to view these tags on a snapshot in the console, but you can see them with the aws CLI, though you have to figure out the ARN:

$ aws rds list-tags-for-resource --resource-name "arn:aws:rds:us-west-2:<my account>:snapshot:<the name of my final snapshot>"
----------------------
| ListTagsForResource|
+--------------------+
||      TagList     ||
|+--------+---------+|
||   Key  |  Value  ||
|+--------+---------+|
||  Tag1  |  tags1  ||
||  Tag2  |  tags2  ||
|+--------+---------+|

Implements #3492

@catsby catsby changed the title B aws rds copy tags to snapshots provider/aws: Add configuration to enable copying RDS tags to final snapshot Oct 16, 2015
@phinze
Copy link
Contributor

phinze commented Oct 28, 2015

LGTM!

catsby added a commit that referenced this pull request Oct 30, 2015
provider/aws: Add configuration to enable copying RDS tags to final snapshot
@catsby catsby merged commit 4db8ef4 into master Oct 30, 2015
@mitchellh mitchellh deleted the b-aws-rds-copy-tags-to-snapshots branch March 22, 2016 19:21
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants