provider/aws: Downcase Route 53 record names in statefile

[catsby]

Route 53 apparently down cases any record name you send it, though this is not documented anywhere I could find.

Currently, if you supply a mixed case name like so:

resource "aws_route53_record" "other" {
    zone_id = "${aws_route53_zone.primary.id}"
    name = "TesTing"
    type = "A"
    ttl = "30"
    records = ["127.0.0.3"]
}

The record will be created, but with a lower case name testing and not TesTing. The resource compares the names as is, so there is no match found.

• https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/resource_aws_route53_record.go#L254

This PR does 3 things:

• stores a lowercase version of the Route 53 name in the state
• uses lowercase for comparison of records from the API
• updates a test to prevent regressions

Fixes #3564 , and should be backwards compatible safe, because if you have a mixed case name right now, then Terraform is giving you a plan/apply loop.

[phinze]

LGTM

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.