Vsphere_virtual_machine: Network interfaces

[eloycoto]

Hi,

This PR fix #3559 and #3560, when a template is cloned we deleted all the interfaces so the createNetworkInterfaces will work correctly.

Regards.

[eloycoto]

Hi,

I've just added a few changes in this PR. Now template didn't change.

The process of the server is the following:

• Get the template.
• Clone template server and keep it off.
• Delete all old network devices and add the spec ones.
• Apply VM customizations (hostname, domain, dns, etc.. )
• PowerOn
• WaitForIP.

This has a new dependency in govmomi, and this PR need to be accepted.

vmware/govmomi#365

P.S: I'll update the godeps when the govmomi get merged.

Cheers

[chrislovecnm]

@eloycoto you sign the CLA for govmomi? See their comments on your PR.

[eloycoto]

Hi,

@chrislovecnm: Yep, is merged now. vmware/govmomi#365

@radeksimko: This should be ok, I've just check that no godeps or glide for the dependencies. So this PR can be merged if you want ;-)

Thanks.

[phinze]

Hi @eloycoto - thanks for this!

A few questions:

• Are you able to run the acceptance tests in your environment?
• Do they pass on this branch?
• Is it possible to add or enhance a test for this new behavior?

[tkak]

@eloycoto I tried to run the acceptance tests in my environment. The test has passed in case of a template containing some network devices. Thank you!

[phinze]

@tkak that is great to hear!

Does that mean you can add a test covering the new behavior if we merge this as is?

[chrislovecnm]

@phinze can we get this merged?

[phinze]

Sounds good - it would still be nice to get a covering acceptance test for the new behavior. But we can merge as-is push that to a separate task.

[chrislovecnm]

@eloycoto any ideas on acceptance testing for this?

@phinze might be tough to write a specific test, because this behavior is based on how the virtual machine template is configured.

[eloycoto]

Hey @chrislovecnm!

Sorry, I was on vacation. I'll send a new PR this week with new test.

Cheers

[chrislovecnm]

👍 @eloycoto

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.