Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: Added preemtible flag to instance_template #3667

Merged

Conversation

lwander
Copy link
Contributor

@lwander lwander commented Oct 28, 2015

Mirrors scheduling options added to instances in #3643 for instance_templates.

@sparkprime

@@ -360,6 +366,10 @@ func resourceComputeInstanceTemplateCreate(d *schema.ResourceData, meta interfac
instanceProperties.Scheduling.OnHostMaintenance = v.(string)
}

if v, ok := d.GetOk("preemptible"); ok {
instanceProperties.Scheduling.Preemptible = v.(bool)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this get populated if preemptible is false, or omitted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default for the API is false so I don't think it matters either way

@lwander lwander force-pushed the f-gcp-instance-template-preemptible branch from af098df to 2da1ba0 Compare October 30, 2015 20:07
sparkprime added a commit that referenced this pull request Oct 30, 2015
…ible

provider/google: Added `preemtible` flag to `instance_template`
@sparkprime sparkprime merged commit 8ff8f17 into hashicorp:master Oct 30, 2015
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants