provider/Azure: various bugfixes #3695
Conversation
| } | ||
|
|
||
| // unfortunately, there's no better way of doing this except | ||
| // polling continuously until it goes away: |
There was a problem hiding this comment.
Can we toss an outer limit timeout on this?
We have a resource.Retry helper that's commonly used elsewhere for this purpose:
https://github.com/hashicorp/terraform/blob/master/helper/resource/wait.go#L12-L36
Example usage:
|
One comment - otherwise this LGTM! |
aznashwan
force-pushed
the
b-azure-fixes
branch
from
172d19d
to
89c36b5
Compare
|
@phinze: I should really spend a day or two in the helper package; at least it'll preventing me from re-inventing wheels which are square compared to you guys' 😄 |
| storageContainterName, fmt.Sprintf(osDiskBlobNameFormat, name), | ||
| ) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Is this error retryable? If you want the error to break the Retry loop immediately, wrap it in a resource.RetryError
aznashwan
force-pushed
the
b-azure-fixes
branch
from
89c36b5
to
1b119cc
Compare
added wait on instance deletion for associated blob deletion. added guarding Mutex for secgroup-rule-related concurrent operations. added usage warning on secgroup rules.
aznashwan
force-pushed
the
b-azure-fixes
branch
from
1b119cc
to
bf09edc
Compare
|
@phinze: good catch on that! Updated and ready to go 😄 |
|
LGTM! Merging... |
provider/Azure: various bugfixes
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
I cannot thank @keymon enough for the most absolutely outrageously amazing bug reports I've received in my life.