provider/aws: Changing the db_instance resource to mark the engine_version as Optional #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,7 +54,7 @@ func resourceAwsDbInstance() *schema.Resource { | |||
|
|
|||
| "engine_version": &schema.Schema{ | |||
| Type: schema.TypeString, | |||
| Required: true, | |||
| Optional: true, | |||
There was a problem hiding this comment.
done and building :)
|
Minor feedback, let me know what you think |
catsby
added
the
waiting-response
|
I think this branch got messed up, there are a bunch of unrelated things in here now |
|
@catsby crap - that's a messed up rebase :( I had to rebase from master |
stack72
force-pushed
the
f-aws-db-instance
branch
from
f4bfbb2
to
e3a66d0
Compare
… is now part of the checkInstanceAttributes func
|
ok @catsby I have fixed the PR branch now - it's ready for checking :) |
catsby
removed
the
waiting-response
|
LGTM thanks @stack72 |
catsby
added a commit
that referenced
this pull request
Nov 10, 2015
provider/aws: Changing the db_instance resource to mark the engine_version as Optional
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3465
The docs actually specify that this is not a required field. Added a test to prove this and I still get an instance up and running