provider/aws: Elasticache cluster describe instances CacheClusterNotFound err handling #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er may have been deleted manually
| @@ -241,6 +241,11 @@ func resourceAwsElasticacheClusterRead(d *schema.ResourceData, meta interface{}) | |||
|
|
|||
| res, err := conn.DescribeCacheClusters(req) | |||
| if err != nil { | |||
| if eccErr, ok := err.(awserr.Error); ok && eccErr.Code() == "CacheClusterNotFound" { | |||
There was a problem hiding this comment.
Let's log before we remove it
log.Printf("[WARN] ElastiCache Cluster (%s) not found", d.Id())
d.SetId("")
return nil
catsby
added
enhancement
waiting-response
|
@catsby done :) |
apparentlymart
removed
the
waiting-response
apparentlymart
added a commit
that referenced
this pull request
Nov 5, 2015
|
Awesome! I squashed this and merged it as 9cee18b. Thanks! |
This was referenced Nov 5, 2015
jen20
added a commit
that referenced
this pull request
Nov 10, 2015
Also adds a regression test using Mock UI. Fixes #3767.
jen20
added a commit
that referenced
this pull request
Nov 10, 2015
Also adds a regression test using Mock UI. Fixes #3767.
|
My bad here, I referenced the wrong issue number in a PR. |
dpetzold
pushed a commit
to clearcare/terraform
that referenced
this pull request
Nov 12, 2015
Also adds a regression test using Mock UI. Fixes hashicorp#3767.
omeid
pushed a commit
to omeid/terraform
that referenced
this pull request
Mar 30, 2018
…dfront_distribution-domain_name-validatefunc resource/aws_cloudfront_distribution: Validate origin domain_name and origin_id at plan time
omeid
pushed a commit
to omeid/terraform
that referenced
this pull request
Mar 30, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the Read method to take into account that an elasticache cluster may have been deleted manually
Fixes #3689
//cc @apparentlymart