provider/digitalocean: Fixing the DigitalOcean Droplet 404 potential on refresh of state

[stack72]

Fixes #3670

Changing the DigitalOcean Droplet resource to use the new SDK message response when a Droplet isn't found

Current behavious in master:

digitalocean_droplet.foobar: Refreshing state... (ID: 8624387)
Error refreshing state: 1 error(s) occurred:

* digitalocean_droplet.foobar: Error retrieving droplet: GET https://api.digitalocean.com/v2/droplets/8624387: 404 The resource you were accessing could not be found.

Then changing the code to cater for the new API lets me do the following:

terraform refresh
digitalocean_droplet.foobar: Refreshing state... (ID: 8624387)
bin % terraform plan
Refreshing Terraform state prior to plan...


The Terraform execution plan has been generated and is shown below.
Resources are shown in alphabetical order for quick scanning. Green resources
will be created (or destroyed and then created if an existing resource
exists), yellow resources are being changed in-place, and red resources
will be destroyed.

Note: You didn't specify an "-out" parameter to save this plan, so when
"apply" is called, Terraform can't guarantee this is what will execute.

+ digitalocean_droplet.foobar
    image:                "" => "centos-5-8-x32"
    ipv4_address:         "" => "<computed>"
    ipv4_address_private: "" => "<computed>"
    ipv6_address:         "" => "<computed>"
    ipv6_address_private: "" => "<computed>"
    locked:               "" => "<computed>"
    name:                 "" => "foo"
    region:               "" => "nyc3"
    size:                 "" => "512mb"
    status:               "" => "<computed>"
    user_data:            "" => "foobar"


Plan: 1 to add, 0 to change, 0 to destroy.

[catsby]

can we check a status code here? Does it provide a 404 ?

[stack72]

@catsby testing this now...

[stack72]

@catsby you are indeed correct - just changed to the 404 status code:

terraform apply
digitalocean_droplet.foobar: Creating...
  image:                "" => "centos-5-8-x32"
  ipv4_address:         "" => "<computed>"
  ipv4_address_private: "" => "<computed>"
  ipv6_address:         "" => "<computed>"
  ipv6_address_private: "" => "<computed>"
  locked:               "" => "<computed>"
  name:                 "" => "foo"
  region:               "" => "nyc3"
  size:                 "" => "512mb"
  status:               "" => "<computed>"
  user_data:            "" => "foobar"
digitalocean_droplet.foobar: Creation complete

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

The state of your infrastructure has been saved to the path
below. This state is required to modify and destroy your
infrastructure, so keep it safe. To inspect the complete state
use the `terraform show` command.

State path: terraform.tfstate
bin % terraform refresh
digitalocean_droplet.foobar: Refreshing state... (ID: 8626268)
bin % terraform plan
Refreshing Terraform state prior to plan...


The Terraform execution plan has been generated and is shown below.
Resources are shown in alphabetical order for quick scanning. Green resources
will be created (or destroyed and then created if an existing resource
exists), yellow resources are being changed in-place, and red resources
will be destroyed.

Note: You didn't specify an "-out" parameter to save this plan, so when
"apply" is called, Terraform can't guarantee this is what will execute.

+ digitalocean_droplet.foobar
    image:                "" => "centos-5-8-x32"
    ipv4_address:         "" => "<computed>"
    ipv4_address_private: "" => "<computed>"
    ipv6_address:         "" => "<computed>"
    ipv6_address_private: "" => "<computed>"
    locked:               "" => "<computed>"
    name:                 "" => "foo"
    region:               "" => "nyc3"
    size:                 "" => "512mb"
    status:               "" => "<computed>"
    user_data:            "" => "foobar"


Plan: 1 to add, 0 to change, 0 to destroy.

[catsby]

Awesome! I think I mentioned this in another PR (well, I know I did, but I lose track of which are yours since you've sent so many 😄 ) but we should log that we couldn't find the specific d.Id() here, right before we d.SetId("")

If you could tack that on, we'll merge this

[stack72]

@catsby sorry! Added now :)

[catsby]

LGTM, merging, thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.