provider/aws: fix panic with SNS topic policy if omitted #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the policy is nil or not before type casting it
This was referenced Nov 5, 2015
|
Looks good @catsby - merging this will fix my acceptance tests :) |
| if v == nil { | ||
| return "" | ||
| } | ||
| jsonb := []byte{} |
There was a problem hiding this comment.
The value of v is ignored here. What about:
s, ok := v.(string)
if !ok || s == "" {
return ""
}
jsonb := []byte(s)
There was a problem hiding this comment.
😱 great catch, thanks @rjeczalik, updated in 15533dc
|
LGTM |
catsby
added a commit
that referenced
this pull request
Nov 10, 2015
provider/aws: fix panic with SNS topic policy if omitted
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds of of #3751, thanks @bobtfish !
ForceNew: false""ifvis nil in StateFunc