providers/aws: Provide source security group id for ELBs #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated with Docs and Test |
| } | ||
| sgId, err := sourceSGIdByName(meta, *lb.SourceSecurityGroup.GroupName, elbVpc) | ||
| if err != nil { | ||
| log.Printf("[WARN] Error looking up ELB Security Group ID: %s", err) |
There was a problem hiding this comment.
Similar to a Q I asked elsewhere today - if there was an error, here, isn't that a big enough deal to stop? Perhaps the answer is "no" but I figure it's worth considering.
There was a problem hiding this comment.
Makes sense, I upgraded it to an error in 7152674
|
LGTM generally! One inline question. |
|
🚢 |
catsby
added a commit
that referenced
this pull request
Nov 10, 2015
providers/aws: Provide source security group id for ELBs
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
source_security_groupreturned for an ELB is the name of the security group... the API only returns the name to us.You cannot use the Security Group name as a reference in the AWS API for security group ingress unless you're in EC2 Classic, or the default VPC. So, if you're trying to ingress from this ELB, and you are not in classic or default VPC, you will hit error(s) (see #2420)
This PR looks up the SG Id and adds
source_security_group_idas an attribute, if found successfullyRemaining: