provider/aws: Ability to reduce nodes in an ElastiCache cluster #3809
Conversation
stack72
changed the title
stack72
force-pushed
the
f-aws-elasticache-cache-nodes-reduction
branch
from
282840a
to
73480cd
Compare
stack72
changed the title
| @@ -173,13 +208,11 @@ resource "aws_security_group" "bar" { | |||
| cidr_blocks = ["0.0.0.0/0"] | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
There's a decent amount of whitespace noise here, could you revisit that?
|
Hi @stack72, other than the minor whitespace issue this looks good to me. While fixing that, if you want to squash the commits that would be good as well :-) |
stack72
force-pushed
the
f-aws-elasticache-cache-nodes-reduction
branch
from
73480cd
to
849c692
Compare
stack72
force-pushed
the
f-aws-elasticache-cache-nodes-reduction
branch
from
849c692
to
2882d01
Compare
|
@jen20 done and done :) |
|
LGTM! |
…eduction provider/aws: Ability to reduce nodes in an ElastiCache cluster
|
I think we should drop a note into the docs as well pointing out the strategy used when reducing the number of nodes - I'll land a PR for that now. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Fixes #3604
Assuptions:
We always remove the higher numbered nodes from the cache cluster
I.e. If we are changing from a 2 node cluster to a 1 node cluster then we remove node_id 0002
If we are changing from a 5 node cluster to a 3 node cluster then we remove node_ids 0005 and 0004