Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: homedir expand in s3 object source #3910

Merged
merged 1 commit into from
Nov 14, 2015

Conversation

phinze
Copy link
Contributor

@phinze phinze commented Nov 13, 2015

fixes #3856

@jen20
Copy link
Contributor

jen20 commented Nov 13, 2015

LGTM, though is this in conflict with our aim of getting rid of file references in favour of file interpolations?

@phinze
Copy link
Contributor Author

phinze commented Nov 13, 2015

@jen20 this resource already supports both styles, and I realized that this resource could be used to upload large and/or binary files, in which case you probably don't want them to be pulled in through an interpolation, so I figured better to just leave this one be.

The motivation is primarily around enabling users to lift sensitive material off disk, and that's already possible here. 👍

radeksimko added a commit that referenced this pull request Nov 14, 2015
provider/aws: homedir expand in s3 object source
@radeksimko radeksimko merged commit d5ae5ba into master Nov 14, 2015
@radeksimko radeksimko deleted the phinze/s3-object-homedir-expand branch November 14, 2015 09:35
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source for aws_s3_bucket_object does not expand ~/<path>
3 participants