Allow targeting orphan nodes #3912
Conversation
This replicates the issue reported in #3852.
| resourceOrphans = append(resourceOrphans, resourceOrphansExcludingTargets[i]) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think going about this filter in the other direction might be a bit more straightforward. Let's see how it looks:
resourceOrphans := state.Orphans(config)
if len(t.Targets) > 0 {
var targetedOrphans []string
for _, o := range resourceOrphans {
targeted := false
for _, t := range t.Targets {
prefix := fmt.Sprintf("%s.%s.%d", t.Type, t.Name, t.Index)
if strings.HasPrefix(o, prefix) {
targeted = true
}
}
if targeted {
targetedOrphans = append(targetedOrphans, o)
}
}
resourceOrphans = targetedOrphans
}Seems sort of nice to have the targeting behavior all behind the guard and the normal case is the straight-through code path. What do you think?
There was a problem hiding this comment.
Likely better, I'll update.
|
This looks 100% correct! One question about style inline, but this is some super solid graph work here. 👍 |
Fixes #3852. We now run the OrphanTransformer even when targeting, and pass it the list of targets following resource expansion.
jen20
force-pushed
the
b-target-orphans
branch
from
cb4c902
to
38bb9f2
Compare
|
LGTM |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Fixes #3852.