provider/openstack: Clean up some attributes in LBaaS VIP resource #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes a few attributes computed so the generated information is accessible after creation. It also fixes the "persistence" attribute, which previously had a typo. Finally, it converts "admin_state_up" to a Boolean to match the majority of other attributes of the same name.
|
I tested this branch against the terraform file I was using in #2908, and the VIP was calculated properly. Good stuff 👍 |
|
@brianvans Awesome, thanks! @phinze Will changing the variable type from String to Bool cause any issues with existing deployments? |
|
@jtopjian everything is coerced into a string down in the state JSON so I believe we should be safe here |
|
@phinze Sounds good. Thanks! |
jtopjian
added a commit
that referenced
this pull request
Nov 18, 2015
…cleanup provider/openstack: Clean up some attributes in LBaaS VIP resource
omeid
pushed a commit
to omeid/terraform
that referenced
this pull request
Mar 30, 2018
`govendor fetch github.com/aws/aws-sdk-go/...@v1.13.21` * Adds support for DynamoDB PITR (hashicorp#3927)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes a few attributes computed so the generated information
is accessible after creation.
It also fixes the "persistent" attribute, which previously had a typo.
Finally, it converts "admin_state_up" to a Boolean to match the majority
of other attributes of the same name.
Fixes #2908