Port Consul provider to new helper.Schema, add Token support #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, it can't be worse. |
|
;) |
| // Resolve the datacenter first, all the other keys are dependent | ||
| // on this. | ||
| var dc string | ||
| if v := d.Get("datacenter"); v != nil { |
There was a problem hiding this comment.
This actually won't work, Get always returns the zero value. You need to do GetOk, which does what you expect...
|
BRING IT IN |
mitchellh
added a commit
that referenced
this pull request
Oct 14, 2014
Port Consul provider to new helper.Schema, add Token support
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, moving from the bespoke API to the helper Schema. This also adds support for ACL tokens.