provider/aws: fix for https://github.com/aws/aws-sdk-go/issues/452 #4024
Conversation
rjeczalik
force-pushed
the
nil-deref-fix
branch
from
aa84e24
to
efaaa0a
Compare
| ) | ||
|
|
||
| var defaultClient = ec2metadata.New(session.New(aws.NewConfig())) |
There was a problem hiding this comment.
The additional aws.NewConfig() is not required when creating a new session. You could do just, ec2metadata.New(session.New()). The config parameter New takes is an optional variadic list of configs which will be merged on top of the session's copy of the default config sourced from the SDK's defaults package.
rjeczalik
force-pushed
the
nil-deref-fix
branch
from
efaaa0a
to
71262c5
Compare
| ) | ||
|
|
||
| var defaultClient = ec2metadata.New(session.New()) |
There was a problem hiding this comment.
Is there any reason for this to be defined here rather than as part of the allocation of ec2rolecreds.EC2RoleProvider on line 49?
There was a problem hiding this comment.
Done. It was there to reuse single var.
|
Hi @rjeczalik! Thanks for submitting this - I agree the change looks correct as per aws/aws-sdk-go#452. I've left a few comments in line on the diffs, could you let me you know what you think? |
rjeczalik
force-pushed
the
nil-deref-fix
branch
from
71262c5
to
9e66e18
Compare
|
@jen20 Addressed, please take a look. |
provider/aws: fix for aws/aws-sdk-go#452
|
Thanks @rjeczalik! I think this may address several crash reports, including #4036. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Fixes nil deref panic caused by aws/aws-sdk-go#452.