Revert changing path.Join() to filepath.Join() (PR #3896)
#4041
Conversation
PR #3896 added support for passing keys by content, but in this same PR all references to `path.Join()` where changed to `filepath.join()`. There is however a significant difference between these two calls and using the latter one now causes issues when running the Chef provisioner on Windows (see issue #4039).
|
@phinze if you can have a look? Looked at adding some tests for this, but there is actually already a test in there for it. The problem is the test will only fail when executed on Windows, as the I'm afraid it didn't caught my eye when reviewing PR #3896, but I think this could/should be a reason to not wait too long with a 0.6.8 release 😞 But maybe wait a little to see if there are more obvious bug that need an immediate fix before doing so... |
|
Ah dang, I definitely thought Will also look into getting a regular Windows test suite run into our processes. |
Revert changing `path.Join()` to `filepath.Join()` (PR #3896)
@phinze @svanharmelen can appveyor be considered in addition to travis? |
|
@joelhandwell I think that would be a good choice for making sure everything works on Windows as well. Don't know how @phinze thinks about it and/or if there is already some Windows testing being done behind the scenes at HashiCorp? |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
PR #3896 added support for passing keys by content, but in this same PR
all references to
path.Join()where changed tofilepath.join().There is however a significant difference between these two calls and
using the latter one now causes issues when running the Chef
provisioner on Windows (see issue #4039).