New AWS resource: aws_lambda_event_source_mapping

[vancluever]

This PR adds a new resource: aws_lambda_event_source_mapping, allowing for the creation of event sources for Lambda functions from either Kinesis or DynamoDB.

This satisfies #3897, and by proxy #4089.

PR includes the resource, the test, and the doc page for the website.

Issues

This resource suffers from the same IAM-related issues that currently other resources are suffering from, manifesting itself through issues like:

Error creating Lambda event source mapping: InvalidParameterValueException: Cannot access
stream arn:aws:kinesis:us-east-1:123456789012:stream/stream_name. Please ensure the role can
perform the GetRecords, GetShardIterator, DescribeStream, and ListStreams Actions on your stream
in IAM.

Any advice on how the best way to fix this would be welcome. Adding the provisioner "local-exec" { command = "sleep SECONDS" } on IAM resources seems to help, but I think long term a better strategy needs to be devised and I'm not too sure if this is the best place to be adding it.

Otherwise, if there's anything else that is required to push this PR thru, let me know.

--Chris

[stack72]

@vancluever this is very nice :) Just ran the tests and go the following:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=EventSourceMapping' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=EventSourceMapping -timeout 90m
=== RUN   TestAccAWSLambdaEventSourceMapping_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_basic (79.25s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    79.265s

Didn't have to worry about the IAM or anything. I am not quite sure about the update func - I'm guessing it would be really good to enable the update for:

• batch size
• enabled / not enabled
• (possibly) function name?

[stack72]

There are some go fmt issues in this block.

[vancluever]

Thanks for the review Paul! Will be working on your suggestions today. Will fix the fmt issues, I am new to Go and am still getting my tools up and running to help with this kind of thing. Will re-push in a bit.

[vancluever]

OK these updates should address the issues - update should now work on all updatable attributes, go fmt is now automatically run on all the code (got my editor tooling all up to snuff), I added the ability to set the mapping to enabled/disabled, and the test has update coverage. Doc has been updated as well.

[stack72]

@vancluever thanks for submitting the updates - will have a test of these this evening

[stack72]

@vancluever this is very nice :) Tests pass as expected:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=EventSourceMapping' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=EventSourceMapping -timeout 90m
=== RUN   TestAccAWSLambdaEventSourceMapping_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_basic (93.17s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    93.181s

I think the Hashicorp team will maybe ask for the commits to be squashed but I'll leave that up to them

Paul

[jen20]

👍 @vancluever this looks great. As @stack72 correctly observes though (!) it would be good if you could squash the commits here so we can maintain as clean a history as possible.

[vancluever]

@jen20 roger that, and all done and pushed!

[stack72]

This looks good - nice work @vancluever :)

[jen20]

Thanks @vancluever! This looks good to me, I'll go ahead and merge.

[vancluever]

Thanks Paul and James!

--Chris

On Dec 1, 2015, at 5:36 AM, James Nugent notifications@github.com wrote:

Merged #4093.

—
Reply to this email directly or view it on GitHub.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.