Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Normalization of SPF records to prevent reporting changes #4108

Merged
merged 1 commit into from
Nov 30, 2015

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Nov 30, 2015

Adding support for the normalizing of Route53 SPF records. Fixes #3230

make testacc TEST=./builtin/providers/aws TESTARGS='-run=Route53Record_spfSupport' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=Route53Record_spfSupport -timeout 90m
=== RUN   TestAccAWSRoute53Record_spfSupport
--- PASS: TestAccAWSRoute53Record_spfSupport (79.17s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    79.185s

@jen20
Copy link
Contributor

jen20 commented Nov 30, 2015

👍 LGTM. Treating SPF records in the same way as TXT makes sense.

jen20 added a commit that referenced this pull request Nov 30, 2015
provider/aws: Normalization of SPF records to prevent reporting changes
@jen20 jen20 merged commit 85c8595 into hashicorp:master Nov 30, 2015
@stack72 stack72 deleted the f-aws-route53-spf-record branch November 30, 2015 13:17
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route53 record updates on no change
2 participants