Allow to specify AWS.Region endpoint to support Eucalyptus flavor of EC2

[elyast]

Feature request, allow to specify endpoint as following:

    region "region x" {
      ec2_endpoint = "http://eucalyptus.escloc57.eecloud.nsn-net.net:8773/services/Eucalyptus"
      s3_endpoint = "..."
    }

How to use goamz with euca: https://www.eucalyptus.com/blog/2014/04/24/using-golang-eucalyptus

[mitchellh]

Good feature request. Tagged.

[elyast]

As far as I checked it could be done in super simple way, but a bit hacky (so allow to pass name as region name or endpoint) and I have verified it works with eucalyptus 3.4.3+

sample config:

provider "aws" {
    access_key = "xxx"
    secret_key = "xxx"
    region = "http://euca-ip:8773/services/Eucalyptus"
}

resource "aws_instance" "web" {
  instance_type = "m1.small"
  ami = "emi-00E03519"
  count = 1
}

and required changes:

diff --git a/builtin/providers/aws/config.go b/builtin/providers/aws/config.go
index 8479cb9..c7f2f06 100644
--- a/builtin/providers/aws/config.go
+++ b/builtin/providers/aws/config.go
@@ -33,15 +33,18 @@ func (c *Config) AWSAuth() (aws.Auth, error) {
 // IsValidRegion returns true if the configured region is a valid AWS
 // region and false if it's not
 func (c *Config) IsValidRegion() bool {
-       var regions = [8]string{"us-east-1", "us-west-2", "us-west-1", "eu-west-1",
-               "ap-southeast-1", "ap-southeast-2", "ap-northeast-1", "sa-east-1"}
+       return true
+}

-       for _, valid := range regions {
-               if c.Region == valid {
-                       return true
+func (c *Config) createRegion() aws.Region {
+  var regions = [8]string{"us-east-1", "us-west-2", "us-west-1", "eu-west-1",
+               "ap-southeast-1", "ap-southeast-2", "ap-northeast-1", "sa-east-1"}
+  for _, valid := range regions {
+    if c.Region == valid {
+                 return aws.Regions[c.Region]
                }
-       }
-       return false
+  }
+  return aws.Region{EC2Endpoint: c.Region}
 }

 // AWSRegion returns the configured region.
@@ -50,7 +53,7 @@ func (c *Config) IsValidRegion() bool {
 func (c *Config) AWSRegion() (aws.Region, error) {
        if c.Region != "" {
                if c.IsValidRegion() {
-                       return aws.Regions[c.Region], nil
+                       return c.createRegion(), nil
                } else {
                        return aws.Region{}, fmt.Errorf("Not a valid region: %s", c.Region)
                }

[wolfspyre]

+1 for this.

[neongazer]

+1 for this

[phinze]

We've had recent users reporting success in using Terraform with Eucalyptus, so I'm going to mark this as closed. Feel free to lobby for reopening if there's still something we're missing in the latest version.

[elyast]

care to share sample config?

[phinze]

@elyast sure! Here's the issue where working config was being tossed around: #1752 (comment)

[elyast]

@phinze looking at the config I am not sure how do u specify region url, additionally looking at: https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/config.go#L127 its hard to believe "eucalyptus" is proper region name...

but if you want to track this feature in #1752 fine with me

[phinze]

Hmm good point @elyast, I wonder if @jeevanullas was working with a custom local build. Your logic makes perfect sense - reopening to track here. Sorry for the mixup!

[jeevanullas]

Hi All,

Thanks @phinze for the ping here. @elyast as terraform uses AWS SDK for Go we just modified the relevant endpoint maps in SDK for Go. This helps us because we also use AWS SDK for Go outside of Terraform. In case you are wondering this is how we did it: jeevanullas/aws-sdk-go@a35daa3

By the way this code in terraform here https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/config.go#L125-L138 can be removed because it is an extra check on the valid regions. Terraform is using AWS SDK for Go so it should rely IMHO on AWS SDK for Go to do the validation.

Please let me know if you have any questions.

Cheers,
Deependra

[lwade]

+1 ref removing https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/config.go#L125-L138

[catsby]

An advantage of ValidateRegion is that we can validate the region in the plan phase of things. Without it, using an invalid region will generate an error at apply time.

[catsby]

Hey friends – I've merged #4263 which allows you to set a custom endpoint for ELB, EC2 and such, so I'm going to close this. Let us know if you need anything else.

[iamfuzz]

Hi, I tried running the asg aws example against a Euca 4.2.2 cloud but it bails out due to "eucalyptus" being an invalid region name. Can you patch the provided go sdk to allow for it as a region name? Thanks!

[gad0lin]

+1, without ability to pass region validation it can't be used with eucalyptus clouds

[zkorinek]

+1 without the possibility to define custom region, the custom endpoints not working.

[gad0lin]

Any chance to remove check against hardcoded endpoint. I have been using terraform on ec2 but can't use it against internal Eucalyptus clouds .

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.