Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Autoscaling Group Scheduled Actions #4256

Merged
merged 2 commits into from
Dec 11, 2015

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Dec 11, 2015

As requested in #2367 & #4211

  • Schema
  • CRUD
  • Acceptance Tests
  • Documentation

Test Results:

TF_LOG=1 make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSAutoscalingSchedule' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSAutoscalingSchedule -timeout 90m
=== RUN   TestAccAWSAutoscalingSchedule_basic
--- PASS: TestAccAWSAutoscalingSchedule_basic (163.86s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    163.882s

@stack72 stack72 changed the title [WIP] provider/aws: Autoscaling Group Scheduled Actions provider/aws: Autoscaling Group Scheduled Actions Dec 11, 2015
Computed: true,
ValidateFunc: validateASGScheduleTimestamp,
},
"end_time": &schema.Schema{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make use of the (new) resource-level ValidateFunc to ensure that end_time > start_time here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this hasn't yet been merged, sorry!

@jen20
Copy link
Contributor

jen20 commented Dec 11, 2015

LGTM! I've put a couple of minor comments inline - not sure if the API validates that end_time > start_time but if so we can make use of the new resource level validation that @phinze added yesterday for that.

jen20 added a commit that referenced this pull request Dec 11, 2015
provider/aws: Autoscaling Group Scheduled Actions
@jen20 jen20 merged commit 19ea14b into hashicorp:master Dec 11, 2015
@stack72 stack72 deleted the aws-asg-scheduled-actions branch December 11, 2015 21:54
@scalp42
Copy link
Contributor

scalp42 commented Dec 11, 2015

@jen20 do you know if you can define a single schedule resource but assign multiple ASGs (pretty much takes an array for autoscaling_group_name) ?

@stack72
Copy link
Contributor Author

stack72 commented Dec 11, 2015

@scalp42 right now, the api only allows a single autoscaling_group_name: http://docs.aws.amazon.com/cli/latest/reference/autoscaling/put-scheduled-update-group-action.html

@scalp42
Copy link
Contributor

scalp42 commented Dec 11, 2015

👍

@stack72
Copy link
Contributor Author

stack72 commented Dec 11, 2015

@scalp42 FWIW its a great suggestion :)

@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants