add support GTD enabled domains to DME provider

[ashmere]

specifically this adds support got gtdlocation to the dnsmadeeasy provider

[ashmere]

@radeksimko do you need me to do anything else to get this accepted?

[ashmere]

@soniah anything you can do to get this accepted?

[soniah]

Hi @ashmere I'm not on the team, so can't do anything :-( But thanks for asking me, reminds me there's things I need to backport to https://github.com/soniah/terraform-provider-dme and vice versa.

Adding Jack Pearkes @pearkes from Terraform, see if he can help.

[ashmere]

Hi @pearkes is there anything that needs doing to get this accepted we have been using this in production for a month with no issues

[jen20]

Hi @ashmere! Thanks for opening this PR - sorry about the amount of time it took to review it. I've rebased it and squashed the commits, and the changes are now on master in 45b3b9d.

While I was working on this one thing I noted was that this provider does not follow the conventions of most others of using _ separators in words - to keep it consistent with itself I merged this one using gtdlocation rather than the usually gtd_location format, but something we may want to consider is deprecating these fields in favour of the usual Terraform schema naming conventions.

Thanks for your work!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.