Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Guard against nil DB Parameter values #4318

Merged
merged 1 commit into from
Dec 14, 2015

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Dec 14, 2015

This PR guards against a nil db parameter group value as shown in #4294 . Unfortunately, several attempts from multiple people have been unable to actually reproduce it, however, there are ~4 cited cases in that ticket across different version of TF, so I'll put this guard in here anyway.

@stack72
Copy link
Contributor

stack72 commented Dec 14, 2015

LGTM! Nice one :)

@apparentlymart apparentlymart changed the title provider/aws: Guard against nil DB Parameter vaules provider/aws: Guard against nil DB Parameter values Dec 14, 2015
@jen20
Copy link
Contributor

jen20 commented Dec 14, 2015

LGTM.

jen20 added a commit that referenced this pull request Dec 14, 2015
provider/aws: Guard against nil DB Parameter values
@jen20 jen20 merged commit a82183f into master Dec 14, 2015
@jen20 jen20 deleted the b-aws-db-param-guard branch December 14, 2015 23:45
@tphummel
Copy link
Contributor

was seeing this error today too. confirmed this fix on master resolves the problem for me. thank you!

@catsby
Copy link
Contributor Author

catsby commented Dec 15, 2015

Excellent, thanks for picking this up @jen20 and thanks for reporting your findings @tphummel 😄

@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants