Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request] Support for Managed NAT Gateway #4374

Closed
cjs opened this issue Dec 17, 2015 · 14 comments
Closed

[feature-request] Support for Managed NAT Gateway #4374

cjs opened this issue Dec 17, 2015 · 14 comments

Comments

@cjs
Copy link

cjs commented Dec 17, 2015

https://aws.amazon.com/blogs/aws/new-managed-nat-network-address-translation-gateway-for-aws/

This just came out, but wanted to get it into the backlog.

@jen20
Copy link
Contributor

jen20 commented Dec 17, 2015

👍 We'll do this as soon as support lands in the AWS SDK for Go!

@nrcxcia
Copy link

nrcxcia commented Dec 17, 2015

+1

@conorgil
Copy link

+1

This would save SO much time and effort! Very excited to see this released by AWS and excited for support in Terraform. The announcement blog post also links to more docs .

I think supporting this will require the following updates:

  1. Create a new resource aws_nat_gateway, which supports something like the following to create a NAT Gateway for each AZ:

    resource "aws_nat_gateway" "main" {
        count = "${length(split(",", var.zones))}"
    
        public_subnet = "${aws_subnet.public.*.id}"
        elastic_ip_address = "${aws_eip.nat.*.id}"
        tags {
          Name = "${var.environment_name}_ngw_for_${element(split(",", var.zones), count.index)_az}"
          environment_name = "${var.environment_name}"
        }
      }
  2. Update aws_route_table and aws_route to support the new NAT gateway. Since those resources already support the gateway_id argument, that could be overloaded to be either the IGW or new NGW resource. If that is complicated to implement, then we could create a new argument nat_gateway_id or something like that.

I am happy to help with docs or anything else non-programming. I haven't dove into Go yet and don't have time at the moment. Let me know how I can help.

@dalethestirling
Copy link

👍 We are excited to integrate this into our standard deployment

@majormoses
Copy link
Contributor

+1

@mtb-xt
Copy link

mtb-xt commented Dec 18, 2015

AWS SDK for Go has just released version 1.0.6, it includes support for NAT Gateways

@jen20
Copy link
Contributor

jen20 commented Dec 18, 2015

This is started in #4381.

@timothykimball
Copy link

+1
Whoop!

@jen20
Copy link
Contributor

jen20 commented Dec 18, 2015

Landed in #4381!

@rajholla
Copy link

Do we have "data source" support for nat gateway's yet?
This is very useful when we need to fetch the NAT gateay id's from existing VPC.

@majormoses
Copy link
Contributor

@rajholla there is no data source for it yet but you could import your existing gateways: https://www.terraform.io/docs/providers/aws/r/nat_gateway.html#import

@nmarchini
Copy link

Is there going to be support for Tags, the current doumentation doesn't allow this and I'm getting the following error when trying to add tags

Errors:

  • aws_nat_gateway.core_nat: : invalid or unknown key: tags

@bflad
Copy link
Contributor

bflad commented Sep 20, 2017

@nmarchini Terraform 0.10.0 now has split providers, like AWS, from the core Terraform repository into their own provider repositories. Please see hashicorp/terraform-provider-aws#1625 which is merged into master of terraform-provider-aws and should be released with version 1.0.0 of the provider.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests