Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add validation for ECR repository name #4431

Merged
merged 2 commits into from
Jan 6, 2016

Conversation

radeksimko
Copy link
Member

I have also moved all existing validation functions into a separate file.

Next step (assuming different PR) can be turning the inline functions that left into standalone functions + adding some tests.

Test plan

$ make test TEST=./builtin/providers/aws TESTARGS='-run=TestValidate'
$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSEcr'
==> Checking that code complies with gofmt requirements...
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSEcr -timeout 90m
=== RUN   TestAccAWSEcrRepositoryPolicy_basic
--- PASS: TestAccAWSEcrRepositoryPolicy_basic (8.84s)
=== RUN   TestAccAWSEcrRepository_basic
--- PASS: TestAccAWSEcrRepository_basic (7.67s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    16.534s

@phinze
Copy link
Contributor

phinze commented Jan 6, 2016

LGTM!

radeksimko added a commit that referenced this pull request Jan 6, 2016
provider/aws: Add validation for ECR repository name
@radeksimko radeksimko merged commit 2edc25e into hashicorp:master Jan 6, 2016
@radeksimko radeksimko deleted the f-aws-validators branch January 6, 2016 16:43
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants