Audit of Google Acceptance Tests for Potential Resource Name Collisions

[phinze]

As we are starting to run the acceptance tests regularly, we're noticing a number of places where two tests can collide because they both attempt to interact with resources of the same name.

I've been making tweaks like these to fix these scenarios:

• 8677f8e
• c4aff4a

I'm being pulled away at the moment - @lwander might you have bandwidth to be able to make a pass through the other tests to make similar changes so they can be run in parallel on Travis?

I know at least we have seen the ComputeGlobalForwardingRule tests collide with health check "tf-test-zero", but there are probably more examples hiding in there.

[phinze]

BTW - Just kicked off a rerun to work around the forwarding rule health check collision - I believe this will be our first green Travis execution of the full Google Acceptance Test suite!

https://travis-ci.org/hashicorp/terraform/builds/100413007

[lwander]

I'm happy to look into this! Do you mean that tests being run in parallel are conflicting due to names being reused?

If the travis run is all green, are we all set?

[phinze]

Do you mean that tests being run in parallel are conflicting due to names being reused?

Yep exactly.

If the travis run is all green, are we all set?

The travis run is green because I manually re-kicked one of the jobs that failed from a collision.

I'm guessing any fixture in the tests with name = "foo" where foo is not an interpolated %s could use a look, so perhaps you can fly through the output of a command like:

git grep 'name \+= \+"[^%]' builtin/providers/google

Not that they'll all need to be changed, but they could probably all use a double check. Once we get all the current tests up to snuff, I'll make sure to keep and eye on this concept in PR reviews going forward. 👍

[lwander]

SGTM!

[phinze]

<3 @lwander

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.