provider/aws: Limit SNS Topic Subscription protocols #4639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| output, err := subscribeToSNSTopic(d, snsconn) | ||
|
|
||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if output.SubscriptionArn != nil && *output.SubscriptionArn == "pending configuration" { |
There was a problem hiding this comment.
I think this a typo s/configuration/confirmation/ - maybe pull the string out into a constant?
|
👍 |
- update the ARN with the new ID
catsby
force-pushed
the
sns-topic-restrictions
branch
from
c7972d4
to
ac60d6b
Compare
catsby
added a commit
that referenced
this pull request
Jan 12, 2016
provider/aws: Limit SNS Topic Subscription protocols
srikalyan
referenced
this pull request
in srikalyan/terraform
Jan 18, 2016
…ubscription. http and https SNS topic subscription endpoints require confirmation to set a valid arn otherwise arn would be set to "pending confirmation". If the endpoints auto confirm then arn is set asynchronously but if we try to create another subscription with same parameters then api returns "pending subscription" as arn but does not create another a duplicate subscription. In order to solve this we should be fetching the subscription list for the topic and identify the subscription with same parameters i.e., protocol, topic_arn, endpoint and extract the subscription arn. Following changes were made to support the http/https endpoints that auto confirms 1. Added 3 extra parameters i.e., 1. endpoint_auto_confirms -> boolean indicates if end points auto confirms 2. max_fetch_retries -> number of times to fetch subscription list for the topic to get the subscription arn 3. fetch_retry_delay -> delay b/w fetch subscription list call as the confirmation is done asynchronously. With these parameters help added support http and https protocol based endpoints that auto confirm. 2. Update website doc appropriately
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some SNS Topic Subscription protocols require an external confirmation before we can get an ARN from the service, and as such they don't fit well with Terraform. Email was already blocked, and this PR expands that to
http(s)andsms, as well.Fixes #2776