provider/aws: aws autoscale schedule 0 values

[stack72]

As per #4690

Added a test to prove that 0 values cannot be specified for the Autoscale Group Schedule resource for min_size, max_size or desirect_capacity even though they are valid values

This shouldn't really be merged until a fix is added for this

[catsby]

I opened stack72#1 to make these fields optional. It's a simple/naive fix... I don't see what the problem would be if the API allows this. Thoughts? What am I missing?

[catsby]

cc @jen20 or @phinze for sanity check, since I contributed here

[stack72]

@catsby I think this is fine with me. I just ran the tests and all passed so this can be merged IMO

[stack72]

@catsby I have tested this and it all looks good now since your changes :)

IMO I think putting 0 as the default is ok - we would need to put it in the release notes that it's not a backwards compatible change

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSAutoscalingSchedule_zero' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSAutoscalingSchedule_zero -timeout 120m
=== RUN   TestAccAWSAutoscalingSchedule_zeroValues
--- PASS: TestAccAWSAutoscalingSchedule_zeroValues (168.52s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    168.536s

I think we can merge this :)

[jen20]

LGTM with test coverage.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.