Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/azurerm: Add azurerm_storage_account #4698

Merged
merged 2 commits into from
Jan 21, 2016
Merged

provider/azurerm: Add azurerm_storage_account #4698

merged 2 commits into from
Jan 21, 2016

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Jan 16, 2016

This is an unusual resource (so far) in that it cannot be created in one call, and instead must be created and the modified to set some of the parameters.

TODO:

  • Complete update function
  • Add acceptance tests
  • Write documentation
$ make testacc TEST=./builtin/providers/azurerm TESTARGS="-run TestAccAzureRMStorageAccount_basic"
==> Checking that code complies with gofmt requirements...
go generate ./...
TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMStorageAccount_basic -timeout 120m
=== RUN   TestAccAzureRMStorageAccount_basic
--- PASS: TestAccAzureRMStorageAccount_basic (835.26s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    835.274s

@jen20 jen20 force-pushed the f-azurerm-storage-account branch 5 times, most recently from 2456910 to f45190b Compare January 21, 2016 00:44
@jen20
provider/azurerm: Add azurerm_storage_account
53c2351 
This is an unusual resource (so far) in that it cannot be created in one
call, and instead must be created and the modified to set some of the
parameters.

We use the pollIndefinitelyWhileNeeded function which will continue to
poll Azure RM operation monitoring endpoints until an error is reported
or the operation meets one of the given status codes. The function was
originally part of this feature but was separated out in order to
unblock other work.

Currently there is no support for the "custom_domain" section of the
storage account API. This was originally present and was later taken out
of the scope of the storage account resource in order that the following
workflow can be used:

1. Create storage account
2. Create DNS CNAME entry once the account name is known
3. Create custom domain mapping
@jen20
Copy link
Contributor Author

jen20 commented Jan 21, 2016

@stack72 Do you want to take a shot at reviewing this one when you get a chance - hopefully this will unblock your work also? Thanks!

@jen20 jen20 changed the title [WIP] provider/azurerm: Add azurerm_storage_account provider/azurerm: Add azurerm_storage_account Jan 21, 2016
@stack72
Copy link
Contributor

stack72 commented Jan 21, 2016

@jen20 this looks great. The addition of withPollWatcher() is going to be a great addition to watch the logs. Do you think we should roll this out across all the clients?

@jen20
Copy link
Contributor Author

jen20 commented Jan 21, 2016

@stack72 there is no harm in including it and the polling code on every resource in my opinion - we have no idea if the underlying API will remain stable, and we should probably respond correctly if we get a 202 from any resource in future including ones which complete immediately at the moment.

jen20 added a commit that referenced this pull request Jan 21, 2016
@jen20
Merge pull request #4698 from hashicorp/f-azurerm-storage-account
c8461ea 
provider/azurerm: Add `azurerm_storage_account`
@jen20 jen20 merged commit c8461ea into master Jan 21, 2016
@jen20 jen20 deleted the f-azurerm-storage-account branch January 21, 2016 12:25
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/azurerm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jen20 @stack72