config: detect provisioner-only resource in JSON and error [GH-4385] #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops some changes I don't want made it in, removing those now. EDIT: Done. |
mitchellh
force-pushed
the
b-detect-weird-json
branch
from
fce7799
to
8e7b0d9
Compare
|
LGTM |
mitchellh
added a commit
that referenced
this pull request
Jan 19, 2016
config: detect provisioner-only resource in JSON and error [GH-4385]
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4385
This detects when a very specific kind of JSON config is input to Terraform and shows an error. A potentially better fix would be to modify the HCL AST in Terraform and transform it to the correct one. This would be a lot of effort compared to this when there is a very easy workaround.
I didn't test this since the test case would have to test the error string itself which I don't like, and otherwise with without this fix you get an error, this just improves the error message.