command: Change module-depth default to -1 #4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,7 +99,7 @@ Options: | |||
| This helps when diagnosing cycle errors. | |||
|
|
|||
| -module-depth=n The maximum depth to expand modules. By default this is | |||
| zero, which will not expand modules at all. | |||
| -1, which will expand modules all modules. | |||
There was a problem hiding this comment.
Should be expand resources within all modules or similar?
There was a problem hiding this comment.
Oh yep, thanks. Doc sweep got sloppy 😛
|
One minor comment on wording otherwise LGTM. |
phinze
force-pushed
the
phinze/module-depth-new-default
branch
from
1add85e
to
de3ce28
Compare
This means that terraform commands like `plan`, `apply`, `show`, and `graph` will expand all modules by default. While modules-as-black-boxes is still very true in the conceptual design of modules, feedback on this behavior has consistently suggested that users would prefer to see more verbose output by default. The `-module-depth` flag and env var are retained to allow output to be optionally limited / summarized by these commands.
phinze
force-pushed
the
phinze/module-depth-new-default
branch
from
de3ce28
to
e67fc0f
Compare
|
@phinze this is awesome! This is going to make using modules a lot more clear :) 👍 |
phinze
added a commit
that referenced
this pull request
Jan 20, 2016
command: Change module-depth default to -1
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that terraform commands like
plan,apply,show, andgraphwill expand all modules by default.While modules-as-black-boxes is still very true in the conceptual design
of modules, feedback on this behavior has consistently suggested that
users would prefer to see more verbose output by default.
The
-module-depthflag and env var are retained to allow output to beoptionally limited / summarized by these commands.