provider/vcd: Add flags for unverified SSL/TLS #4811
Conversation
superseb
changed the title
|
Hi @superseb! Thanks for opening a pull request - looks like there are some build issues, and also one or two whitespace formatting issues here - could you take a look at those and then we can merge this in? Agreed it's a useful flag - several other providers have this option. |
| url = "${var.vcd_url}" | ||
| vdc = "${var.vcd_vdc}" | ||
| maxRetryTimeout = "${var.vcd_maxRetryTimeout}" | ||
| allow_unverified_ssl = "${var.vcd_allow_unverified_ssl}" |
There was a problem hiding this comment.
This looks like a whitespace concern
superseb
force-pushed
the
vcd_unverified_ssl
branch
from
ce2ebf7
to
6fe6ff4
Compare
|
Thanks for taking a look @jen20 . The build errors occur because a needed lib is not yet updated (hmrc/vmware-govcd#4), so I marked it as WIP. The docs are fixed, didn't appear like that on my end but should be good now. |
superseb
changed the title
|
Dependency has been merged, retrigged CI by closing and reopening PR. Can you take a look @jen20 ? |
|
Yup, looks like this should fix it up! Thanks @superseb! |
provider/vcd: Add flags for unverified SSL/TLS
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Ability to configure to allow insecure SSL/TLS certificates. Useful for test environments that don't have a proper certificate (chain) or some appliances don't have proper certificates anyway. This should be identical behaviour as the configuration for the vSphere provider.
Before this can be merged, we have to wait for hmrc/vmware-govcd#4 to be merged. This then should be used in a new release.
This PR fixes #4620