provider/openstack: Per-network Floating IPs #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtopjian
force-pushed
the
openstack-per-network-floating-ip
branch
2 times, most recently
from
1b0aa6a
to
6e93c2d
Compare
This commit adds the ability to associate a Floating IP to a specific network. Previously, there only existed a top-level floating IP attribute which was automatically associated with either the first defined network or the default network (when no network block was used). Now floating IPs can be associated with networks beyond the first defined network as well as each network being able to have their own floating IP. Specifying the floating IP by using the top-level floating_ip attribute and the per-network floating IP attribute is not possible. Additionally, an `access_network` attribute has been added in order to easily specify which network should be used for provisioning.
jtopjian
force-pushed
the
openstack-per-network-floating-ip
branch
from
6e93c2d
to
df660a2
Compare
jtopjian
added a commit
that referenced
this pull request
Jan 31, 2016
provider/openstack: Per-network Floating IPs
jtopjian
added a commit
to jtopjian/terraform
that referenced
this pull request
Feb 28, 2016
hashicorpGH-4812 removed reading server.AccessIPv4 and server.AccessIPv6 because, AFAICT, they are not set by Nova. After removal, a user reported that they were no longer able to read IPs from access_ip_v4 and access_ip_v6 on Rackspace. It's possible that Rackspace sets the AccessIPv* attributes, and if that's true, other cloud providers might as well through custom extensions. The priority of how access_ip_v* is set might require some tweaks in the future.
bigkraig
pushed a commit
to bigkraig/terraform
that referenced
this pull request
Mar 1, 2016
hashicorpGH-4812 removed reading server.AccessIPv4 and server.AccessIPv6 because, AFAICT, they are not set by Nova. After removal, a user reported that they were no longer able to read IPs from access_ip_v4 and access_ip_v6 on Rackspace. It's possible that Rackspace sets the AccessIPv* attributes, and if that's true, other cloud providers might as well through custom extensions. The priority of how access_ip_v* is set might require some tweaks in the future.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to associate a Floating IP to a specific network.
Previously, there only existed a top-level floating IP attribute which was
automatically associated with either the first defined network or the default
network (when no network block was used).
Now floating IPs can be associated with networks beyond the first defined
network as well as each network being able to have their own floating IP.
Specifying the floating IP by using the top-level floating_ip attribute and
the per-network floating IP attribute is not possible.
Additionally, an
access_networkattribute has been added in order to easilyspecify which network should be used for provisioning.
Fixes #4677