provider/aws: Provide a better message if no AWS creds are found

[catsby]

$ terraform apply 
Error refreshing state: 1 error(s) occurred:

* 1 error(s) occurred:

* No valid credential sources found for AWS Provider.
  Please see https://terraform.io/docs/providers/aws/index.html for more information on
  providing credentials for the AWS Provider

[radeksimko]

👍

aws/aws-sdk-go#512 should allow us to give users more details about where the credentials come from - helpful for further debugging. I'll probably send something in a separate PR.

[phinze]

The shared credentials path can be overridden with AWS_SHARED_CREDENTIALS_FILE

And the creds file can have multiple profiles, which can be selected via profile, which can also be set via AWS_PROFILE.

https://github.com/aws/aws-sdk-go/blob/87b1e60a50b09e4812dee560b33a238f67305804/aws/credentials/shared_credentials_provider.go#L25-L36

I wonder if this would look clearer as a numbered list of "things we check in this order" than a prose paragraph?

[catsby]

I wonder if this would look clearer as a numbered list of "things we check in this order" than a prose paragraph?

probably, will do

[phinze]

Big 👍 for getting a link to website docs in this error message - that way we can continue to improve that message as we learn more about what's helpful to users.

Made some comments on the initial contents of the website message above inline.

[phinze]

LGTM

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.