provider/openstack: Fix crash when access_network was not defined #4966
Conversation
jtopjian
force-pushed
the
openstack-fix-access-network
branch
from
8714bc9
to
240268c
Compare
| @@ -998,7 +998,7 @@ func getInstanceAccessAddresses(d *schema.ResourceData, networks []map[string]in | |||
| hostv6 = n["fixed_ip_v6"].(string) | |||
| } | |||
|
|
|||
| if n["access_network"].(bool) { | |||
| if ok, an := n["access_network"].(bool); ok && an { | |||
There was a problem hiding this comment.
Should these be named the opposite way around for clarity? Appreciate that it doesn't actually matter here, but the "ok" is generally the second parameter of the type assertion?
There was a problem hiding this comment.
Yes indeed. I should really just step away from any keyboard for the rest of the day.
|
Hi @jtopjian! I've left a comment in line - the nature of the fix looks fine, with one minor nitpick. Thanks for opening the PR! |
jtopjian
force-pushed
the
openstack-fix-access-network
branch
from
240268c
to
7ccaaa1
Compare
|
Thanks for the review. Should be good now. |
provider/openstack: Fix crash when access_network was not defined
|
@phinze I was swamped at work and wanted to fix this bug ASAP. Now that the dust has settled, I've had some time to review and I'm utterly confused as to why this bug was triggered. Most specifically, I was only able to recreate this bug by compiling Terraform to a binary and then applying a fresh config. This bug didn't trigger during any acceptance tests nor on existing configurations when used as a binary. Any ideas? |
|
Can we soon get a 0.6.12 including this patch? :) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Fixes #4954