provider/azurerm: Add azurerm_dns_zone resource
#4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resource is the first which makes use of the new Riviera library (at https://github.com/jen20/riviera), so there is some additional set up work to add the provider to the client which gets passed among resources.
| createResponse, err := createRequest.Execute() | ||
| if err != nil { | ||
| return fmt.Errorf("Error creating DNS Zone: %s", err) | ||
| } else if !createResponse.IsSuccessful() { |
There was a problem hiding this comment.
I believe it's a bit more go-idiomatic to drop the else and just proceed with a second if
There was a problem hiding this comment.
Correct - I thought I had changed that already but apparently not. New commit pushed rectifying all the occurrences of this.
|
This LGTM! This superceeds my PR #4662 so will close that |
stack72
added a commit
that referenced
this pull request
Feb 3, 2016
provider/azurerm: Add `azurerm_dns_zone` resource
4 tasks
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resource is the first which makes use of the new Riviera library (at https://github.com/jen20/riviera), so there is some additional set up work to add the provider to the client which gets passed among resources.