Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for CloudWatch Events #4986

Merged
merged 7 commits into from
Feb 13, 2016

Conversation

radeksimko
Copy link
Member

This is closing #4827

TODO list:

  • Implementation of aws_cloudwatch_event_rule
  • Implementation of aws_cloudwatch_event_target
  • Documentation for aws_cloudwatch_event_rule
  • Documentation for aws_cloudwatch_event_target
  • Acceptance tests for aws_cloudwatch_event_rule
  • Acceptance tests for aws_cloudwatch_event_target
  • Workaround for cases where user deletes target or rule outside of TF
  • Example with Kinesis
  • Example with SNS
  • Example with Lambda - this functionally depends on provider/aws: Add aws_lambda_permission #4826

@radeksimko
Copy link
Member Author

This is now ready for review.

"schedule_expression": &schema.Schema{
Type: schema.TypeString,
Optional: true,
ValidateFunc: validateMaxLength(256),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this little helper! This will be able to be used elsewhere :)

@stack72
Copy link
Contributor

stack72 commented Feb 12, 2016

@radeksimko this looks really good - i've made a few comments on some possible questions but apart from that it LGTM

@radeksimko
Copy link
Member Author

@stack72 I fixed all of the things you reported except one. I hope the reasons make sense.

I reran all related tests after making the changes & Travis also returns green now, so I'm merging this.

radeksimko added a commit that referenced this pull request Feb 13, 2016
provider/aws: Add support for CloudWatch Events
@radeksimko radeksimko merged commit 0e66f67 into hashicorp:master Feb 13, 2016
@radeksimko radeksimko deleted the f-aws-cloudwatch-events branch February 13, 2016 13:29
@stack72
Copy link
Contributor

stack72 commented Feb 13, 2016

Thanks for the fixes @radeksimko :)

@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants