-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Add support for CloudWatch Events #4986
provider/aws: Add support for CloudWatch Events #4986
Conversation
6b4a6b5
to
efae60c
Compare
This is now ready for review. |
"schedule_expression": &schema.Schema{ | ||
Type: schema.TypeString, | ||
Optional: true, | ||
ValidateFunc: validateMaxLength(256), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this little helper! This will be able to be used elsewhere :)
@radeksimko this looks really good - i've made a few comments on some possible questions but apart from that it LGTM |
efae60c
to
30e5ec7
Compare
@stack72 I fixed all of the things you reported except one. I hope the reasons make sense. I reran all related tests after making the changes & Travis also returns green now, so I'm merging this. |
provider/aws: Add support for CloudWatch Events
Thanks for the fixes @radeksimko :) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This is closing #4827
TODO list:
aws_cloudwatch_event_rule
aws_cloudwatch_event_target
aws_cloudwatch_event_rule
aws_cloudwatch_event_target
aws_cloudwatch_event_rule
aws_cloudwatch_event_target
Example with Lambda- this functionally depends on provider/aws: Add aws_lambda_permission #4826