Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Expose additional VPN Connection attributes. #5032

Merged
merged 3 commits into from
Feb 12, 2016
Merged

provider/aws: Expose additional VPN Connection attributes. #5032

merged 3 commits into from
Feb 12, 2016

Conversation

clstokes
Copy link
Contributor

@clstokes clstokes commented Feb 6, 2016

Adds four new attributes to the aws_vpn_connection resource:

tunnel1_address
tunnel1_preshared_key
tunnel2_address
tunnel2_preshared_key

Docs are updated and an acceptance test for the XML parsing is included.

These attributes are parsed from the CustomerGatewayConfiguration XML data provided back from AWS (and already exposed on the aws_vpn_connection resource).

Exposing these attributes separately from the full XML data allows for further automation of the other side of the AWS VPN connection, such as connecting to a VPN Gateway at Google.

@catsby
Copy link
Contributor

catsby commented Feb 12, 2016

LGTM, thanks!

catsby added a commit that referenced this pull request Feb 12, 2016
provider/aws: Expose additional VPN Connection attributes.
@catsby catsby merged commit 169b63e into hashicorp:master Feb 12, 2016
@clstokes clstokes deleted the f-aws-gateway-tunnel-info branch February 12, 2016 17:13
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants