Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google subnetworks #5130

Closed
wants to merge 4 commits into from

Conversation

sl1pm4t
Copy link
Contributor

@sl1pm4t sl1pm4t commented Feb 14, 2016

Add support for Google's new subnetted networks, which is the default going forward:
https://cloud.google.com/compute/docs/subnetworks

  • update google_compute_network resource to allow creation of auto subnetted and custom subnetted networks
  • add google_compute_subnetwork resource
  • update other google compute resources that may need to reference a subnetwork
  • update docs
  • update acceptance tests

@sl1pm4t sl1pm4t changed the title [WIP] add support for Google subnetworks Add support for Google subnetworks Feb 16, 2016
@sl1pm4t
Copy link
Contributor Author

sl1pm4t commented Feb 16, 2016

This PR updates some of the vendored Google Cloud client libraries. I wasn't sure if including the updated libraries in the PR is the desired approach.

@jen20 jen20 self-assigned this Feb 17, 2016
@jen20
Copy link
Contributor

jen20 commented Feb 17, 2016

Hi @sl1pm4t - your approach of including the updated dependency is correct. I'm testing this now, and hope to merge it shortly! Thanks for your contribution!

@jen20
Copy link
Contributor

jen20 commented Feb 18, 2016

@sl1pm4t - I rebased this prior to merging and cleaned up a few comments. It landed in fe52b43 and the commits prior to that. Thanks for contribution!

@sl1pm4t
Copy link
Contributor Author

sl1pm4t commented Feb 22, 2016

@jen20 - a backwards compatibility issue was found with this change. See #5233.
I've submitted PR #5241 to fix.
Thanks!

@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants