VPC support for Lambda functions

[vincer]

Fix for #5105

Note that I had to update the aws-sdk to 1.1.2.

I'm pretty new to go so please let me know of any improvements I can make.

[radeksimko]

This is looking pretty good on the first sight, all I can tell from a quick skim-through is that we'll also need to update docs.

I will have a deeper look at the code once I finish with the other Lambda related PRs:

• provider/aws: Add aws_lambda_permission #4826
• Lambda S3 object version defaults to $LATEST if unspecified #4770
• Adding support for Lambda function updates #3825

[vincer]

Oh, yeah! Docs! Good call, will update.

Edit: done.

[jen20]

Thanks @vincer and @radeksimko! Ran the integration tests locally and all seems to be well.

$ make testacc TEST=./builtin/providers/aws TESTARGS="-run TestAccAWSLambda"
=== RUN   TestAccAWSLambdaAlias_basic
--- PASS: TestAccAWSLambdaAlias_basic (10.77s)
=== RUN   TestAccAWSLambdaEventSourceMapping_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_basic (83.78s)
=== RUN   TestAccAWSLambdaFunction_basic
--- PASS: TestAccAWSLambdaFunction_basic (13.68s)
=== RUN   TestAccAWSLambdaPermission_basic
--- PASS: TestAccAWSLambdaPermission_basic (17.61s)
=== RUN   TestAccAWSLambdaPermission_withRawFunctionName
--- PASS: TestAccAWSLambdaPermission_withRawFunctionName (17.68s)
=== RUN   TestAccAWSLambdaPermission_withQualifier
--- PASS: TestAccAWSLambdaPermission_withQualifier (17.59s)
=== RUN   TestAccAWSLambdaPermission_multiplePerms
--- PASS: TestAccAWSLambdaPermission_multiplePerms (31.14s)
=== RUN   TestAccAWSLambdaPermission_withS3
--- PASS: TestAccAWSLambdaPermission_withS3 (18.27s)
=== RUN   TestAccAWSLambdaPermission_withSNS
--- PASS: TestAccAWSLambdaPermission_withSNS (18.53s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    229.083s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.