Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: improve vpc cidr_block err message #5255

Merged
merged 1 commit into from
Feb 22, 2016

Conversation

phinze
Copy link
Contributor

@phinze phinze commented Feb 22, 2016

Pull CIDR block validation into a shared func ready to be used elsewhere

Example of new err message:

Errors:

  * aws_vpc.foo: "cidr_block" must contain a valid network CIDR,
    expected "10.0.0.0/16", got "10.0.1.0/16"

Pull CIDR block validation into a shared func ready to be used elsewhere

Example of new err message:

```
Errors:

  * aws_vpc.foo: "cidr_block" must contain a valid network CIDR,
    expected "10.0.0.0/16", got "10.0.1.0/16"
```
@phinze phinze force-pushed the phinze/improve-vpc-cidr-errmsg branch from b7af14b to ce74e3d Compare February 22, 2016 22:47
@phinze phinze changed the title provider/aws: improve network cidr_block err message provider/aws: improve vpc cidr_block err message Feb 22, 2016
@stack72
Copy link
Contributor

stack72 commented Feb 22, 2016

LGTM!

phinze added a commit that referenced this pull request Feb 22, 2016
provider/aws: improve vpc cidr_block err message
@phinze phinze merged commit 5528abb into master Feb 22, 2016
@phinze phinze deleted the phinze/improve-vpc-cidr-errmsg branch February 22, 2016 22:54
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants