Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/docker: #5298 Add support for docker run --user option #5300

Merged
merged 1 commit into from
Apr 5, 2016
Merged

provider/docker: #5298 Add support for docker run --user option #5300

merged 1 commit into from
Apr 5, 2016

Conversation

lvjp
Copy link
Contributor

@lvjp lvjp commented Feb 24, 2016

Implement add support for the docker run option

@stack72
Copy link
Contributor

stack72 commented Mar 9, 2016

Hi @lvjp, please can you rebase this from master. There is no need to make a change to the CHANGELOG file - this is done when the PR is merged so we can make sure that the issue gets logged with the correct release

@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Mar 9, 2016
@lvjp
Copy link
Contributor Author

lvjp commented Mar 9, 2016

Alright, I will try to do it within a day.

@stack72
Copy link
Contributor

stack72 commented Mar 9, 2016

Thanks so much! No need to rush :)

@lvjp
Copy link
Contributor Author

lvjp commented Mar 10, 2016

Done

@jen20 jen20 removed the waiting-response An issue/pull request is waiting for a response from the community label Mar 16, 2016
@jen20
Copy link
Contributor

jen20 commented Mar 16, 2016

Hi @lvjp! Thanks for doing this - the code looks good to me. One more minor change - could you remove the CHANGELOG entry from the PR - we generally do this on master as it leads to merge conflicts (as in this case!)

@stack72
Copy link
Contributor

stack72 commented Apr 5, 2016

Hi @lvjp

This looks good now - thanks so much for removing the CHANGELOG entry

Paul

@stack72 stack72 merged commit a24207b into hashicorp:master Apr 5, 2016
@lvjp lvjp deleted the b-docker-container-user branch December 27, 2016 20:12
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants