Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix crash creating rules in aws SGs #5329

Merged
merged 1 commit into from
Feb 26, 2016
Merged

provider/aws: Fix crash creating rules in aws SGs #5329

merged 1 commit into from
Feb 26, 2016

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Feb 25, 2016

This commit uses Group Name in preference to Group ID where appropriate in the aws_security_group_rule resource. This fixes the crash reported in #5310.

Fixes #5310.

Unfortunately this does not appear to impact the tests in #4983, which will need examining separately.

This commit uses Group Name in preference to Group ID where appropriate
in the aws_security_group_rule resource. This fixes the crash reported
in #5310.

Fixes #5310.
@phinze
Copy link
Contributor

phinze commented Feb 25, 2016

What a world! LGTM

jen20 added a commit that referenced this pull request Feb 26, 2016
provider/aws: Fix crash creating rules in aws SGs
@jen20 jen20 merged commit f249a43 into master Feb 26, 2016
@jen20 jen20 deleted the b-5310 branch February 26, 2016 19:44
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform crashed on apply
2 participants