Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda S3 object version defaults to '$LATEST' if unspecified #5370

Conversation

radeksimko
Copy link
Member

This is a rebased and polished version of #4770

Essentially I just resolved conflicts with some latest changes in the Lambda Function acceptance tests and replaced rand.New(rand.NewSource(time.Now().UnixNano())).Int() with acctest.RandInt().

The original credit obviously goes to @Bowbaq 😉

I will merge this myself once Travis turns green since it's just polished version of someone else's PR and the changes were quite trivial, but feel free to do code review afterwards.

I also ran acceptance tests:

TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSLambdaFunction -timeout 120m
=== RUN   TestAccAWSLambdaFunction_basic
--- PASS: TestAccAWSLambdaFunction_basic (30.24s)
=== RUN   TestAccAWSLambdaFunction_VPC
--- PASS: TestAccAWSLambdaFunction_VPC (33.40s)
=== RUN   TestAccAWSLambdaFunction_s3
--- PASS: TestAccAWSLambdaFunction_s3 (32.21s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    95.874s

radeksimko added a commit that referenced this pull request Feb 29, 2016
…not-required

Lambda S3 object version defaults to '$LATEST' if unspecified
@radeksimko radeksimko merged commit 5aafacc into hashicorp:master Feb 29, 2016
@radeksimko radeksimko deleted the mb-lambda-s3-object-version-not-required branch February 29, 2016 14:49
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants