Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix error parsing JSON in S3 bucket policy #5474

Merged
merged 1 commit into from
Mar 7, 2016

Conversation

kjmkznr
Copy link
Contributor

@kjmkznr kjmkznr commented Mar 6, 2016

Specific empty string into S3 bucket policy, cause following error.

Error parsing JSON: unexpected end of JSON input
  • template
resource "aws_s3_bucket" "bucket" {
    bucket = "tf-test-bucket"
    policy = ""
}

This commit change output following:

Before:

"" -> "Error parsing JSON: unexpected end of JSON input"

After:

"" -> ""

@jen20
Copy link
Contributor

jen20 commented Mar 6, 2016

Hi @kjmkznr - thanks for opening this pull request! It looks good to me and the test coverage is good, but you could squash the commits into one and rebase onto master, then force push back to your branch? Thanks!

Before:

"" -> "Error parsing JSON: unexpected end of JSON input"

After:

"" -> ""
@kjmkznr kjmkznr force-pushed the skip-normalize-empty-policy branch from 423d86d to 8d1292d Compare March 7, 2016 00:32
@kjmkznr
Copy link
Contributor Author

kjmkznr commented Mar 7, 2016

Thanks reply.
I squashed commits!

stack72 added a commit that referenced this pull request Mar 7, 2016
provider/aws: Fix error parsing JSON in S3 bucket policy
@stack72 stack72 merged commit 46e4717 into hashicorp:master Mar 7, 2016
@kjmkznr kjmkznr deleted the skip-normalize-empty-policy branch April 17, 2016 16:59
@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants